Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message with importing a chain #5669

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Improve error message with importing a chain #5669

merged 1 commit into from
Feb 25, 2021

Conversation

ghoneycutt
Copy link
Contributor

Without this commit the error message does not provide much value as it
lacks context.

Kubuxu
Kubuxu reviewed Feb 24, 2021
View reviewed changes
cmd/lotus/daemon.go Outdated Show resolved Hide resolved
@ghoneycutt
Improve error message with importing a chain
92b6054 
Without this commit the error message does not provide much value as it
lacks context.
@ghoneycutt
Copy link
Contributor Author

@Kubuxu I have made the change you requested.

@ghoneycutt ghoneycutt requested a review from Kubuxu February 25, 2021 00:30
@magik6k magik6k changed the base branch from master to next February 25, 2021 13:30
@magik6k
Copy link
Contributor

magik6k commented Feb 25, 2021

(merging into #5679)

@magik6k magik6k merged commit f5d819b into filecoin-project:next Feb 25, 2021
@ghoneycutt ghoneycutt deleted the import_error branch February 25, 2021 18:22
@ghoneycutt
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@Kubuxu Kubuxu Kubuxu approved these changes

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghoneycutt @magik6k @Kubuxu